More granularity for AndroidExcludedRefs #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The goal is to allow an app that fixed a known leak to stop excluding that leak, so that it gets reported if it's not correctly fixed. * `AndroidExcludedRefs` is an enum * `AndroidExcludedRefs` static methods are still here * However, you can also create you own enum set and build the corresponding ExcludedRefs from that. API changes: * `LeakCanary.install(Application, Class<? extends AbstractAnalysisResultService>, ExcludedRefs)` * `LeakCanary.androidWatcher(HeapDump.Listener, ExcludedRefs)`
| @@ -106,8 +88,10 @@ | |||
| // Application.onCreate() and pass it the application context. | |||
| excluded.staticField("android.media.session.MediaSessionLegacyHelper", "sInstance"); | |||
| } | |||
There was a problem hiding this comment.
Those diffs. I fucking love Git.
|
Thanks @fabiendevos for the idea! |
| @@ -31,51 +38,24 @@ | |||
| * We filter on SDK versions and Manufacturers because many of those leaks are specific to a given | |||
| * manufacturer implementation, they usually share their builds across multiple models, and the | |||
| * leaks eventually get fixed in newer versions. | |||
| * | |||
| * Most app developers should use {@link #createAppDefaults()}. However, you can also pick the | |||
|
The enum is great. |
swankjesse
added a commit
that referenced
this pull request
May 13, 2015
More granularity for AndroidExcludedRefs
|
Thanks @swankjesse :) |
Yky
pushed a commit
to Yky/leakcanary
that referenced
this pull request
Feb 21, 2016
More granularity for AndroidExcludedRefs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to allow an app that fixed a known leak to stop excluding that leak, so that it gets reported if it's not correctly fixed.
AndroidExcludedRefsis an enumAndroidExcludedRefsstatic methods are still hereAPI changes:
LeakCanary.install(Application, Class<? extends AbstractAnalysisResultService>, ExcludedRefs)LeakCanary.androidWatcher(HeapDump.Listener, ExcludedRefs)