Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

leak_canary_watcher_auto_install is marked as private #1863

Closed
eygraber opened this issue Jun 17, 2020 · 4 comments · Fixed by #1864 or #1869
Closed

leak_canary_watcher_auto_install is marked as private #1863

eygraber opened this issue Jun 17, 2020 · 4 comments · Fixed by #1864 or #1869
Labels
type: bug
Milestone
2.5

Comments

@eygraber
Copy link
Contributor

I started using leak_canary_watcher_auto_install so I can manually install LeakCanary, but lint is warning me that it is a private resource.
This was referenced Jun 17, 2020
Closed
Merged
@pyricau
Copy link
Member

pyricau commented Jun 17, 2020

Good point!

We probably need to do the same for https://github.com/square/leakcanary/blob/main/plumber-android/src/main/res/values/plumber_bools.xml#L3

@pyricau pyricau reopened this Jun 17, 2020
@pyricau
Copy link
Member

pyricau commented Jun 17, 2020

Reopening until we fix leak_canary_plumber_auto_install as well

@eygraber
Copy link
Contributor Author

Same for leak_canary_allow_in_non_debuggable_build.

Should those go in the same public file? If so, I can make a PR for that.

@eygraber eygraber mentioned this issue Jun 18, 2020
Merged
@pyricau
Copy link
Member

pyricau commented Jun 18, 2020

Ah, no, it should be the public file of the module where they're declared

@pyricau pyricau added this to the 2.5 milestone Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug
Projects
None yet
Milestone
2.5
2 participants
@pyricau @eygraber