Memory leak in HeapAnalyzer

[HexBlit]

I am seeing a strictmode error with leakCanary that gives a possible memory leak.

A resource was acquired at attached stack trace but never released.
java.lang.Throwable: Explicit termination method 'end' not called
at com.squareup.leakcanary.HeapAnalyzer.openSnapshot(HeapAnalyzer.java:134)

[pyricau]

Can you provide the full stacktrace please?

Also, which version of LeakCanary are you using?

[ninja-]

@pyricau the snapshot is not disposed

[HexBlit]

06-04 10:23:49.508: E/StrictMode(2323): at com.squareup.leakcanary.HeapAnalyzer.openSnapshot(HeapAnalyzer.java:134)
com.squareup.leakcanary.HeapAnalyzer.checkForLeak(HeapAnalyzer.java:87)
com.squareup.leakcanary.internal.HeapAnalyzerService.onHandleIntent(HeapAnalyzerService.java:56)

Here is the strict mode error that I am getting.

[HexBlit]

Here is a better stack trace result

 A resource was acquired at attached stack trace but never released. See java.io.Closeable for information on avoiding resource leaks.
 java.lang.Throwable: Explicit termination method 'end' not called
    at dalvik.system.CloseGuard.open(CloseGuard.java:184)
    at java.util.zip.Inflater.<init>(Inflater.java:82)
    at java.util.zip.ZipFile.getInputStream(ZipFile.java:331)
    at java.util.jar.JarFile.getInputStream(JarFile.java:390)
    at libcore.net.url.JarURLConnectionImpl.getInputStream(JarURLConnectionImpl.java:222)
    at java.net.URL.openStream(URL.java:470)
    at java.lang.ClassLoader.getResourceAsStream(ClassLoader.java:444)
    at org.eclipse.mat.util.MessageUtil.<init>(MessageUtil.java:27)
    at org.eclipse.mat.util.MessageUtil.<clinit>(MessageUtil.java:13)
    at org.eclipse.mat.util.MessageUtil.format(MessageUtil.java:18)
    at org.eclipse.mat.hprof.HprofIndexBuilder.fill(HprofIndexBuilder.java:54)
    at org.eclipse.mat.parser.internal.SnapshotFactory.parse(SnapshotFactory.java:193)
    at org.eclipse.mat.parser.internal.SnapshotFactory.openSnapshot(SnapshotFactory.java:106)
    at com.squareup.leakcanary.HeapAnalyzer.openSnapshot(HeapAnalyzer.java:134)
    at com.squareup.leakcanary.HeapAnalyzer.checkForLeak(HeapAnalyzer.java:87)
    at com.squareup.leakcanary.internal.HeapAnalyzerService.onHandleIntent(HeapAnalyzerService.java:56)
    at android.app.IntentService$ServiceHandler.handleMessage(IntentService.java:65)
    at android.os.Handler.dispatchMessage(Handler.java:102)
    at android.os.Looper.loop(Looper.java:135)
    at android.os.HandlerThread.run(HandlerThread.java:61)

[pop1030123]

there any solutions?

[ninja-]

yeah add snapshot.dispose() @pop1030123

[pyricau]

@ninja- com.squareup.leakcanary.HeapAnalyzer#cleanup does call dispose, and is called in a finally block. Do you have more details about what the fix should be?

[pyricau]

We're switching the backend in #219