-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion: Make did:pkh completely based on new caip10 spec #238
Comments
Great suggestion. I think we can perhaps add :caip10: as a submethod....or perhaps default to caip10 methods if not explicitly defined in did-pkh. This would allow the specification some flexibility to work with non-CAIP/non-blockchain PKH reprs, such as GPG fingerprints.
I'm okay with a lot of these, but prefer explicitness where possible. |
I would prefer if we don't end up with a lot of different ways to represent a single account-id. Imo we should select one of these options and stick with it! See your point on non-CAIP PKHs though. In theory we could create caip10 specs for these as well. This is the case for Radicle which is not a blockchain id. If we could converge between caip10 and did:pkh it would be awesome since it seems we are trying to achieve a lot of similar things. |
Agreed! I like the idea that we accept CAIP-10 registration as a top-level submethod, e.g., +1 to convergence |
Closed by #252 |
@bumblefudge This should not be closed by #252! The main thing that needs to be update in the spec is how DIDs are represented. |
My mistake! Will update the spec ASAP to reflect the code as soon as the changes have been fully integrated |
Thanks :) |
Let's try to get this next week. cc @bumblefudge |
So this is mostly just an idea that I think would simplify things, however the caip10 spec is not yet settled.
Suggestion: make the DID PKH be represented as:
This would mean that we always include the chainId, so it may break existing identifiers, but it would make the PKH spec much more clear!
Examples
A benefit of using this approach is that we automatically can support new blockchains that are added to the CAIP repo without having to change the PKH spec at all.
Note, this is based on the discussion taking place here: ChainAgnostic/CAIPs#51
The text was updated successfully, but these errors were encountered: