Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix turnstile and showcase sample #1178

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hpoettker
Copy link

Resolves #1176

With the changes from this PR, the samples turnstile, turnstilereactive, and showcase work as described in the reference documentation.

I didn't check the other samples interactively, but their tests are still successful.

As all samples are Spring Boot applications, I've added the Spring Boot Gradle Plugin to the SamplePlugin. This lets the build produce executable jars that can be started with java -jar as described in the documentation.

To get the Spring Shell apps for the turnstile and showcase working, I've

  • enabled auto-configuration with @SpringBootApplication
  • removed the application context XML (no longer required with @SpringBootApplication)
  • added the spring-shell-starter
  • set the property spring.shell.interactive.enabled=true
  • added @CommandScan to pick up the sample commands

The other Spring Shell apps like e.g. the CD player should be fixable with the same approach.

The warning on start-up of the samples about the StateMachineAnnotationPostProcessorConfiguration can be resolved by #1157 .

Signed-off-by: Henning Pöttker <25299532+hpoettker@users.noreply.github.com>
@hpoettker hpoettker force-pushed the fix-spring-shell-apps branch from 247c8e1 to 4271090 Compare February 9, 2025 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to run samples
1 participant