Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1176
With the changes from this PR, the samples turnstile, turnstilereactive, and showcase work as described in the reference documentation.
I didn't check the other samples interactively, but their tests are still successful.
As all samples are Spring Boot applications, I've added the Spring Boot Gradle Plugin to the
SamplePlugin
. This lets the build produce executable jars that can be started withjava -jar
as described in the documentation.To get the Spring Shell apps for the turnstile and showcase working, I've
@SpringBootApplication
@SpringBootApplication
)spring-shell-starter
spring.shell.interactive.enabled=true
@CommandScan
to pick up the sample commandsThe other Spring Shell apps like e.g. the CD player should be fixable with the same approach.
The warning on start-up of the samples about the
StateMachineAnnotationPostProcessorConfiguration
can be resolved by #1157 .