Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InMemoryReactiveClientRegistrationRepository should check for duplicates #7338

Closed
jzheaux opened this issue Sep 2, 2019 · 0 comments
Closed

InMemoryReactiveClientRegistrationRepository should check for duplicates #7338

jzheaux opened this issue Sep 2, 2019 · 0 comments
Assignees
@jzheaux
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement
Milestone
5.2.0.RC1

Comments

@jzheaux
Copy link
Contributor

jzheaux commented Sep 2, 2019

It's likely a misconfiguration to construct a ClientRegistration repository with duplicate primary keys.

As such, InMemoryClientRegistrationRepository fails if two registrations with the same id are provided. InMemoryReactiveClientRegistrationRepository does not do this, but it should.
@jzheaux jzheaux self-assigned this Sep 2, 2019
@jzheaux jzheaux added in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement labels Sep 2, 2019
@jzheaux jzheaux added this to the 5.2.0.RC1 milestone Sep 2, 2019
@jzheaux jzheaux closed this as completed in 5e98b92 Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jzheaux jzheaux

Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement
Projects
None yet
Milestone
5.2.0.RC1
Development

No branches or pull requests
1 participant
@jzheaux