Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider renaming OidcIdTokenDecoderFactory #6425

Closed
jgrandja opened this issue Jan 14, 2019 · 4 comments
Closed

Consider renaming OidcIdTokenDecoderFactory #6425

jgrandja opened this issue Jan 14, 2019 · 4 comments
Assignees
@jgrandja
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) status: declined A suggestion or change that we don't feel we should currently apply

Comments

@jgrandja
Copy link
Contributor

We may need to rename OidcIdTokenDecoderFactory and ReactiveOidcIdTokenDecoderFactory to be more specific, given that both factories create JwtDecoder using ClientRegistration.ProviderDetails.jwkSetUri for it's key source. There will likely be other factory implementations that create JwtDecoder using a different key source, e.g. statically configured key(s).

#5465 may provide some ideas around the possible rename.

Related #6379
@jgrandja jgrandja added Refactoring in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) labels Jan 14, 2019
@jgrandja jgrandja added this to the 5.2.0.M2 milestone Jan 14, 2019
@jgrandja jgrandja self-assigned this Jan 14, 2019
@jgrandja jgrandja mentioned this issue Jan 15, 2019
Closed
@raphaelDL
Copy link
Contributor

Something like:

OidcIdTokenDecoderWithJwkSetUriFactory

🤔

@jgrandja
Copy link
Contributor Author

jgrandja commented Jan 15, 2019 •
edited
Loading

Yeah I was thinking something similar - with JwkSet in the name - but I'm not convinced we want it in the name. This one can wait until #5465 is done which I'm starting work on.

If you're looking for another ticket to work on and having trouble finding one let me know.

@raphaelDL
Copy link
Contributor

yup maybe another one, please

@jgrandja
Copy link
Contributor Author

Closing this as the current names make sense and therefore no need to rename.

@jgrandja jgrandja removed this from the 5.2.0.M2 milestone Apr 12, 2019
@jgrandja jgrandja added status: declined A suggestion or change that we don't feel we should currently apply and removed Refactoring labels Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jgrandja jgrandja

Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@raphaelDL @jgrandja