Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update in FragmentsRendering to names of static methods #33974

Closed
rstoyanchev opened this issue Nov 27, 2024 · 0 comments
Closed

Update in FragmentsRendering to names of static methods #33974

rstoyanchev opened this issue Nov 27, 2024 · 0 comments
Assignees
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Milestone

Comments

@rstoyanchev
Copy link
Contributor

FragmentsRendering#with methods have caused some confusion, making it look like adding a full template name first, and then fragment names through the builder. However, we are collecting a uniform list of fragments each consisting of a view (name) and optional model.

We should use fragment and fragments for the method names instead to be more clear:

FragmentsRendering
        .fragment("todos :: foo")
        .fragment("todos :: bar")
        .build();
@rstoyanchev rstoyanchev added in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement labels Nov 27, 2024
@rstoyanchev rstoyanchev added this to the 6.2.1 milestone Nov 27, 2024
@rstoyanchev rstoyanchev self-assigned this Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant