Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upcoming release of webjars-locator-lite #33693

Closed
dodgex opened this issue Oct 13, 2024 · 1 comment
Closed

Upcoming release of webjars-locator-lite #33693

dodgex opened this issue Oct 13, 2024 · 1 comment
Labels
status: invalid An issue that we don't feel is valid

Comments

@dodgex
Copy link

dodgex commented Oct 13, 2024

With the deprecation of support for webjars-locator-core in Spring Framework 6.2 (havent found a confirmation) and Spring Boot 3.4 (as of https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-3.4.0-M1-Release-Notes), I wonder what the chances are to get the (hopefully soon) upcoming release of webjars-locator-lite into 6.2 / 3.4.

Currently there is a PR webjars/webjars-locator-lite#15 (related issue) open to add the ability to use custom webjars and even old (officiall unsupported) bower based webjars with webjars-locator-lite by providing a META-INF/webjars/locator.properties mapping a webjar name to a version.

While this reintroduces some classpath scanning that you guys tried to get rid of by switching to the lite locator, but I think the overhead should be way less than in the previous locator.

While it is not strictly necessary to get the upgraded version directly from the upcoming release, it could make migrating to the new locator possible (without overriding the dependency version) for projects using bower (should be able to switch to non-bower variants) or custom webjars (would need to change the groupId to one of the two supported by webjar-locator-lite).

I have no Idea on when the PR is going to be merged, although the current feedback seems positive, or when it is going to be release and with which version number. So this is primarily asking for the overall chance and possible deadlines for a release of the webjars locator to get into the upcoming Spring Versions.

Thanks in advance!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Oct 13, 2024
@bclozel
Copy link
Member

bclozel commented Oct 13, 2024

Milestone dates are public on GitHub, for example the upcoming RC2 is scheduled this week: https://github.com/spring-projects/spring-framework/milestone/380

If those changes are merely internal and don't change the API, then it's mostly a dependency management concern and Spring Boot will pick up automatically the new version when it's out. Let's figure things out when this PR is merged and we know what this means for the Spring integration.

Thanks!

@bclozel bclozel added status: invalid An issue that we don't feel is valid and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Oct 13, 2024
@bclozel bclozel closed this as not planned Won't fix, can't repro, duplicate, stale Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: invalid An issue that we don't feel is valid
Projects
None yet
Development

No branches or pull requests

3 participants