Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support SameSite attribute in CookieGenerator #27596

Closed
ldap4life opened this issue Oct 22, 2021 · 2 comments
Closed

Support SameSite attribute in CookieGenerator #27596

ldap4life opened this issue Oct 22, 2021 · 2 comments
Labels
for: external-project Needs a fix in external project in: web Issues in web modules (web, webmvc, webflux, websocket)

Comments

@ldap4life
Copy link

ldap4life commented Oct 22, 2021 •
edited by sbrannen
Loading

Affects: 5.3.10

Context: I'm using CookieLocaleResolver, and I have a requirement to have explicit SameSite policies on all cookies.

It would be nice if CookieGenerator let the SameSite attribute be set.

Spring Session has CookieSerializer which is nice and covers the session cookie.

Thank you.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Oct 22, 2021
@sbrannen sbrannen added the in: web Issues in web modules (web, webmvc, webflux, websocket) label Oct 23, 2021
@sbrannen sbrannen changed the title Let CookieGenerator set samesite attribute Support SameSite attribute in CookieGenerator Oct 23, 2021
@sbrannen
Copy link
Member

If you are using Spring Boot, the upcoming 2.6 release will provide support for setting the SameSite attribute. See spring-projects/spring-boot#20971 for details.

@ldap4life
Copy link
Author

Thanks this should suffice.

@sbrannen sbrannen closed this as not planned Won't fix, can't repro, duplicate, stale Dec 13, 2022
@sbrannen sbrannen added for: external-project Needs a fix in external project and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
for: external-project Needs a fix in external project in: web Issues in web modules (web, webmvc, webflux, websocket)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sbrannen @spring-projects-issues @ldap4life