Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use shared InjectionMetadata instance for beans skipped by AutowiredAnnotationBeanPostProcessor #22570

Closed
Tracked by #22560
philwebb opened this issue Mar 12, 2019 · 0 comments
Closed
Tracked by #22560

Use shared InjectionMetadata instance for beans skipped by AutowiredAnnotationBeanPostProcessor #22570

philwebb opened this issue Mar 12, 2019 · 0 comments
Assignees
@jhoeller
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: task A general task
Milestone
5.2 M1

Comments

@philwebb
Copy link
Member

Currently AutowiredAnnotationBeanPostProcessor.buildAutowiringMetadata creates a new InjectionMetadata instance with an empty collection for beans that have no relevant annotations. It looks like the clazz parameter never escapes from the class so we could probably create a special shared InjectionMetadata.EMPTY instance to return in such cases.
@philwebb philwebb mentioned this issue Mar 12, 2019
Closed
23 tasks
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Mar 12, 2019
@sbrannen sbrannen added the in: core Issues in core modules (aop, beans, core, context, expression) label Mar 12, 2019
@jhoeller jhoeller self-assigned this Mar 12, 2019
@jhoeller jhoeller removed the status: waiting-for-triage An issue we've not yet triaged or decided on label Mar 12, 2019
@jhoeller jhoeller added this to the 5.2 M1 milestone Mar 12, 2019
@jhoeller jhoeller added the type: task A general task label Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhoeller jhoeller

Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: task A general task
Projects
None yet
Milestone
5.2 M1
Development

No branches or pull requests
4 participants
@sbrannen @philwebb @jhoeller @spring-projects-issues