Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase StringBuilder initial size used in the ASM Frame class #22565

Closed
Tracked by #22560
philwebb opened this issue Mar 11, 2019 · 0 comments
Closed
Tracked by #22560

Increase StringBuilder initial size used in the ASM Frame class #22565

philwebb opened this issue Mar 11, 2019 · 0 comments
Assignees
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: task A general task
Milestone

Comments

@philwebb
Copy link
Member

The ASM Frame class builds typeDescriptor strings using a StringBuilder. It turns out that almost all descriptors are bigger than StringBuilder's default size of 16. Increasing the default size to 32 means that that AbstractStringBuilder.ensureCapacityInternal doesn't need to call Arrays.copyOf as often.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Mar 11, 2019
@sbrannen sbrannen added the in: core Issues in core modules (aop, beans, core, context, expression) label Mar 12, 2019
@jhoeller jhoeller self-assigned this Mar 12, 2019
@jhoeller jhoeller removed the status: waiting-for-triage An issue we've not yet triaged or decided on label Mar 12, 2019
@jhoeller jhoeller added this to the 5.2 M1 milestone Mar 12, 2019
@jhoeller jhoeller added the type: task A general task label Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: task A general task
Projects
None yet
Development

No branches or pull requests

4 participants