Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specifying null handling for 'sort' query params [DATAREST-1098] #1409

Open
spring-projects-issues opened this issue Jun 20, 2017 · 4 comments
Assignees
Labels
type: enhancement A general enhancement

Comments

@spring-projects-issues
Copy link

Casey Link opened DATAREST-1098 and commented

It should be possible (or would be very nice!) to be able to specify the null handling when sorting a response with spring-data-rest.

This is quite important for our use cases, as we have some tables where nulls should be sorted last or first, depending on the specific field.

I see two possibilities here:

  1. the sort query param accepts an additional positional argument like ?sort=name,desc,nullslast
  2. QuerydslBinderCustomizer and QuerydslBindings are extended such that the sort details can be customized on the repository.
{
    default void customize(QuerydslBindings bindings, QPerson person)
    {
        bindings.bind(person.name).sort().nullsLast();
    }

Affects: 2.6.4 (Ingalls SR4)

1 votes, 3 watchers

@spring-projects-issues
Copy link
Author

Oliver Drotbohm commented

I like your phrasing of "it should be possible". It indeed should. Unfortunately with JPA, it isn't. See the link to the JPA Github above

@spring-projects-issues
Copy link
Author

member sound commented

Could you please add this as a feature? Using spring-data-rest is so nice, but lacking the possibility on how to sort nulls is crucial!

@membersound
Copy link

It would still be great investigating into this issue.

@odrotbohm
Copy link
Member

We did. And unfortunately nothing has changed in the mean time:

I like your phrasing of "it should be possible". It indeed should. Unfortunately with JPA, it isn't. See the link to the JPA Github above.

The upstream ticket for reference:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

3 participants