Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to Spring Data Commons' association abstraction. #938

Closed
wants to merge 1 commit into from

Conversation

odrotbohm
Copy link
Member

Deprecated Spring Data JDBC's custom PersistentProperty.isReference() in favor of the already existing ….isAssociation() with the same semantics to benefit from association definitions implemented in Spring Data Commons. Make use of the newly introduced PersistentEntity.doWithAll(…) to apply the previously existing property handling to both properties and now associations, too.

Deprecated Spring Data JDBC's custom PersistentProperty.isReference() in favor of the already existing ….isAssociation() with the same semantics to benefit from association definitions implemented in Spring Data Commons. Make use of the newly introduced PersistentEntity.doWithAll(…) to apply the previously existing property handling to both properties and now associations, too.
@odrotbohm odrotbohm force-pushed the feature/associations branch from bedb677 to 4c11fbc Compare March 11, 2021 12:39
@schauder schauder self-requested a review March 12, 2021 09:57
@schauder schauder self-assigned this Mar 12, 2021
@schauder schauder added this to the 2.2 M5 (2021.0.0) milestone Mar 12, 2021
@schauder schauder added the type: enhancement A general enhancement label Mar 12, 2021
schauder pushed a commit that referenced this pull request Mar 12, 2021
Deprecated Spring Data JDBC's custom PersistentProperty.isReference() in favor of the already existing ….isAssociation() with the same semantics to benefit from association definitions implemented in Spring Data Commons. Make use of the newly introduced PersistentEntity.doWithAll(…) to apply the previously existing property handling to both properties and now associations, too.

Original pull request #938
schauder added a commit that referenced this pull request Mar 12, 2021
Improves tests by also testing for the negative case.

Original pull request #938
@schauder
Copy link
Contributor

Thanks, that's merged.

@schauder schauder closed this Mar 12, 2021
@odrotbohm odrotbohm deleted the feature/associations branch March 15, 2021 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants