Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove converter warnings regarding java.time.OffsetDateTime with mysql dialect #1122

Closed
dataGeeek opened this issue Jan 5, 2022 · 0 comments
Assignees
Labels
type: bug A general bug

Comments

@dataGeeek
Copy link

Dear Spring Data team,

we are using spring-data-jdbc together with mysql and receive the following warn log after upgrading to version 2.3.0 every time the spring context boot up:

WARN o.s.data.convert.CustomConversions: Registering converter from class java.time.OffsetDateTime to class org.springframework.data.jdbc.core.convert.JdbcValue as writing converter although it doesn't convert to a store-supported type! You might want to check your annotation setup at the converter implementation.

It looks like, storing entities with a java.time.OffsetDateTime type works fine - therefore we think the warning is misleading and should be removed.

You can find a demo project to reproduce the problem here: demo Just run the application test and watch the console.

After digging a bit through the code, it looks like the following class adds the OffsetDateTime converter:
org.springframework.data.jdbc.core.dialect.JdbcMySqlDialect.

Thanks for looking into this.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 5, 2022
@mp911de mp911de added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 10, 2022
schauder added a commit that referenced this issue Jan 12, 2022
schauder added a commit that referenced this issue Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

No branches or pull requests

4 participants