Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize startup time SpringCacheAnnotationParser #8056

Closed
philwebb opened this issue Jan 21, 2017 · 5 comments
Closed

Optimize startup time SpringCacheAnnotationParser #8056

philwebb opened this issue Jan 21, 2017 · 5 comments
Labels
for: external-project For an external project and not something we can fix

Comments

@philwebb
Copy link
Member

Looking at the PetClinc it appears that SpringCacheAnnotationParser might be a hotspot. It searches every method in the app for @Cache... annotations. Not sure if there's much we can do, it might be a Spring issue. It seems a little related to the performance of AnnotatedElementUtils.
@philwebb
Copy link
Member Author

screen shot 2017-01-21 at 7 11 57 am

@philwebb
Copy link
Member Author

@jhoeller Can you see anything obvious that could be done to improve the annotation processing performance. I wonder if calling isAnnotated first and perhaps somehow caching to save on meta-annotation recursion?

@snicoll
Copy link
Member

snicoll commented Jan 22, 2017

@philwebb I am confused, SpringCacheAnnotationParser is in Spring Framework isn't it?

@philwebb
Copy link
Member Author

@snicoll Yes, I have a feeling that this will ultimately be something we can't fix in Boot.

@bclozel bclozel added the theme: performance Issues related to general performance label Mar 22, 2018
@philwebb
Copy link
Member Author

philwebb commented Feb 1, 2019

This is a known issue (also with EventListener) and we're investigating various options in Spring Framework see spring-projects/spring-framework#22175

@philwebb philwebb closed this as completed Feb 1, 2019
@philwebb philwebb added for: external-project For an external project and not something we can fix and removed theme: performance Issues related to general performance type: enhancement A general enhancement labels Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
for: external-project For an external project and not something we can fix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bclozel @snicoll @philwebb