Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize startup time: cache configuration #7576

Open
dsyer opened this issue Dec 6, 2016 · 3 comments
Open

Optimize startup time: cache configuration #7576

dsyer opened this issue Dec 6, 2016 · 3 comments
Labels
theme: performance Issues related to general performance type: enhancement A general enhancement

Comments

@dsyer
Copy link
Member

dsyer commented Dec 6, 2016

The Pet Clinic depends on EhCache, but it doesn't even use it unless the "production" profile is enabled. And yet it costs a couple hundred ms apparently (see benchmarks at https://github.com/dsyer/spring-boot-startup-bench). This might be just a special case of too much condition processing on startup, but I did notice that all cache types are configured in CacheConfigurationImportSelector, even if they are switched off by condition processing, and maybe this is unnecessary.

@philwebb philwebb added this to the 1.5.0 milestone Dec 6, 2016
@snicoll
Copy link
Member

snicoll commented Dec 7, 2016

I noticed that too and we should revisit the condition to back-off sooner indeed. If you have an app with nothing particular on the classpath, the cache conditions always shows up which is not nice at all.

@snicoll snicoll modified the milestone: 1.5.0 Jan 16, 2017
@philwebb philwebb added the theme: performance Issues related to general performance label Jan 25, 2019
@philwebb philwebb added this to the General Backlog milestone Jan 25, 2019
@philwebb
Copy link
Member

@dsyer I know you've been looking at pet clinic again recently. Did this issue end up being a quirk of the report (#13509) or was it legit? What are the steps we need to follow to replicate?

@dsyer
Copy link
Member Author

dsyer commented Jan 27, 2019

Some analysis: spring-attic/spring-init#5. The benchmark code is there as well I think (in the petclinic sample inside that project). See also this Spring Framework issue: spring-projects/spring-framework#22175.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme: performance Issues related to general performance type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

4 participants