Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify 'observation-enabled' property defaults if possible #38737

Closed
philwebb opened this issue Dec 11, 2023 · 2 comments
Closed

Unify 'observation-enabled' property defaults if possible #38737

philwebb opened this issue Dec 11, 2023 · 2 comments
Labels
status: superseded An issue that has been superseded by another

Comments

@philwebb
Copy link
Member

See #36451 and #38644 for examples.

Currently some technologies have an observation-enabled property which can be used to enable/disable observations. We should try to align the default value of this property for all of them.

There may be performance reasons why we currently don't enable all observations by default.
@philwebb philwebb added the type: enhancement A general enhancement label Dec 11, 2023
@philwebb philwebb added this to the 3.x milestone Dec 11, 2023
@philwebb philwebb mentioned this issue Dec 12, 2023
Closed
@mhalbritter
Copy link
Contributor

mhalbritter commented Dec 12, 2023 •
edited
Loading

Currently, we have:

  • spring.kafka.listener.observation-enabled with default false
  • spring.kafka.template.observation-enabled with default false
  • spring.pulsar.listener.observation-enabled with default true

After #36451, we additionally have:

  • spring.rabbitmq.template.observation-enabled with default false
  • spring.rabbitmq.listener.simple.observation-enabled with default false
  • spring.rabbitmq.listener.direct.observation-enabled with default false
  • spring.rabbitmq.listener.stream.observation-enabled with default false

@Wzy19930507 Wzy19930507 mentioned this issue Jan 23, 2024
Closed
@mhalbritter
Copy link
Contributor

Superseded by #39276.

@mhalbritter mhalbritter closed this as not planned Won't fix, can't repro, duplicate, stale Jan 31, 2024
@mhalbritter mhalbritter added status: superseded An issue that has been superseded by another and removed type: enhancement A general enhancement labels Jan 31, 2024
@mhalbritter mhalbritter removed this from the 3.x milestone Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: superseded An issue that has been superseded by another
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unify 'observation-enabled' property defaults Wzy19930507/spring-boot
2 participants
@philwebb @mhalbritter