Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modularizing Spring #20903

Closed
rolaca11 opened this issue Apr 9, 2020 · 1 comment
Closed

Modularizing Spring #20903

rolaca11 opened this issue Apr 9, 2020 · 1 comment
Labels
status: duplicate A duplicate of another issue

Comments

@rolaca11
Copy link

rolaca11 commented Apr 9, 2020

I'm sorry if this topic has come up a million times before, but I couldn't find an official statement about what the plans are for incorporating the JPMS into the Spring framework.

This feature has obviously received a lot of bad rep from the community, but I think it can open up interesting opportunities for the framework. Especially for Spring Boot, a @ConditionalOnModule annotation could be a nice addition, giving developers another set of tools into their auto-configuration repertoire.

By design, implementing this feature would not break projects that are not making use of modularity, since unnamed modules have access to all available modules. It also seems like Java 8 based projects are fine since JDK 8 just ignores the module-info.class altogether.

I have worked a bunch with JPMS lately, so I understand that a feature like this takes more than 5 minutes to implement and takes a lot of effort testing in the first iteration, however, I also feel like this feature would be worth the effort.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 9, 2020
@snicoll
Copy link
Member

snicoll commented Apr 10, 2020

I'm sorry if this topic has come up a million times before, but I couldn't find an official statement about what the plans are for incorporating the JPMS into the Spring framework.

#13799 and in particular this comment should give you a bit more context about our position.

See also spring-projects/spring-framework#18079.

@snicoll snicoll closed this as completed Apr 10, 2020
@snicoll snicoll added status: duplicate A duplicate of another issue and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: duplicate A duplicate of another issue
Projects
None yet
Development

No branches or pull requests

3 participants