Support feedback reminders and closure for pull requests

[wilkinsona]

Currently, the Bot only monitors PRs that are waiting for feedback to label them as feedback provided if/when appropriate. We'd like to expand this to cover pull requests too, but with different messages and possibly different time periods than we use for issues.

For issues we allow 7 days for feedback before a reminder is posted. We then allow another 7 days before closing the issue. The issue reminder message is the following:

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

The issue closure message is the following:

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue.

We'll need different messages for pull requests and we could consider a different time period too

[wilkinsona]

This change will affect the Boot (@philwebb), Framework (@rstoyanchev), Security (@rwinch) and Session (@vpavic) teams.

[wilkinsona]

To get the ball rolling, here's a proposal for the pull request reminder message:

If you would like us to be able process this pull request, please provide the requested information. If the information is not provided with the next n days, we will be unable to proceed and this pull request will be closed.

And for the pull request closure message:

Closing due to lack of requested feedback. If you would like to proceed with your contribution, please provide the request information and we will re-open this pull request.

[sbrannen]

Since a PR often involves reviews, "requested information" may not be applicable. Instead, "requested changes" may be more appropriate. I therefore suggest the following.

Reminder Message:

If you would like us to be able process this pull request, please provide the requested information or make the requested changes. If the information is not provided or the requested changes are not made within the next N days, we will be unable to proceed and this pull request will be closed.

Closure Message:

Closing due to lack of requested feedback. If you would like to proceed with your contribution, please provide the requested information or make the requested changes and we will re-open this pull request.

[wilkinsona]

I like that. Thanks, Sam.

All, any thoughts on the time period for reminders and closure? I wonder if we should give people a bit longer for a pull request. 14 days rather than 7?

[sbrannen]

14 days sounds good to me.

[sbrannen]

Are there any plans to implement this feature?

[wilkinsona]

I'm afraid I'd rather forgotten about this one. Sorry. No concrete plans at the moment. It shouldn't be too hard to implement but I have other things on my plate at the moment that are more important.