Skip to content
This repository has been archived by the owner on Mar 2, 2022. It is now read-only.

Emtpy implementation for reactor.core.scala.publisher.ParallelFlux #21

Closed
denyshorman opened this issue Mar 2, 2019 · 6 comments
Closed
Assignees

Comments

@denyshorman
Copy link

denyshorman commented Mar 2, 2019

I see some inconsistency between between reactor.core.publisher.ParallelFlux and reactor.core.scala.publisher.ParallelFlux. Scala ParallelFlux is empty.
Do you have plans to add some methods to this class ?
Thanks

@sinwe
Copy link
Contributor

sinwe commented Mar 4, 2019

Hi,

Do you have plans to add some methods to this class ?

Yes, of course. I just don't have the use case yet. If you have the use case, I can add it.

@denyshorman
Copy link
Author

Hi.
Ideal case for me would be to add all methods from Java ParallelFlux and add public method toJava (convert to Java ParallelFlux; currently I even can't convert it to java version because it is marked as private).
But if it is not possible, would be good to add common method: runOn, subscribe, map, filter, flatMap, concatMap, reduce, sequential.

@sinwe
Copy link
Contributor

sinwe commented Mar 4, 2019

Thanks for your feedback.
I've released version 0.3.7 with a method to convert to Java for now so you can access its underlying ParallelFlux.
In the meantime, I'll update it with the common methods as you said.
If you could also gives me a list of methods that you used, that'll be a good use case for me.

@sinwe sinwe self-assigned this Mar 4, 2019
@denyshorman
Copy link
Author

Many thanks @sinwe !
I use runOn operator to specify scheduler, then filter to filter inputs, then map to run heavy computation, and then sequential to merge the results.

@sinwe
Copy link
Contributor

sinwe commented Mar 5, 2019 via email

@denyshorman
Copy link
Author

No, I need to use sequential in order to pass computed results to other operators like scan.

@sinwe sinwe closed this as completed Jul 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

2 participants