Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test is failing due to dependency issue with ts-jest #224

Closed
fastfrwrd opened this issue Feb 26, 2020 · 0 comments · Fixed by #236
Closed

Test is failing due to dependency issue with ts-jest #224

fastfrwrd opened this issue Feb 26, 2020 · 0 comments · Fixed by #236
Labels
bug Something isn't working test Changes to the testing strategy, or proposed new tests

Comments

@fastfrwrd
Copy link

It seems that this PR will fix it, once it is released: kulshekhar/ts-jest#1408
@fastfrwrd fastfrwrd added bug Something isn't working test Changes to the testing strategy, or proposed new tests labels Feb 26, 2020
fastfrwrd pushed a commit that referenced this issue Mar 12, 2020
test(web-scripts): unbreak integration test
1a039ec 
update to install jest-config, which is improperly included in ts-jest at the moment

fix #224
@fastfrwrd fastfrwrd mentioned this issue Mar 12, 2020
Merged
fastfrwrd pushed a commit that referenced this issue Mar 12, 2020
Fix issues that are causing the build to fail (#236)
88b5654 
* test(web-scripts): unbreak integration test

update to install jest-config, which is improperly included in ts-jest at the moment

fix #224

* fix: remove "incremental" from tsconfigs

incremental and noEmit cannot be used together anymore; should folks want to use incremental in the
future, they need to set it themselves via an override.

fix #215
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working test Changes to the testing strategy, or proposed new tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issues that are causing the build to fail spotify/web-scripts
1 participant
@fastfrwrd