Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for MS SQL Server #67

Open
unusualmutant opened this issue Jun 28, 2019 · 2 comments
Open

Add support for MS SQL Server #67

unusualmutant opened this issue Jun 28, 2019 · 2 comments

Comments

@unusualmutant
Copy link

Currently this DB is not supported as a source, but is widely used. Would be great to have the option of reading from MS SQL Server tables as well.

@labianchin
Copy link
Collaborator

Thanks for raising this!

There has been a PR #32 , but it did not went further. I don't think there is any plan currently to add support for it.

When designing for MS SQL Server support we need to consider:

  1. Design to interoperate with other DBeam features (e.g. --partition, --limit, -queryParallelism, ...) in a maintainable way (i.e. avoiding if isMsSQLServer() everywhere).
  2. Add some good test coverage on this feature so that we can keep confidence to evolve DBeam. It would be great to have some e2e tests covering Google Cloud SQL and Google Dataflow offering, but the reality is that would be quite some investment.

@rulle-io
Copy link
Contributor

The issue with having a mssql jdbc library not included into dbeam package can be solved by providing a option to add(load) a 3rd-party library at runtime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants