Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Standardized Way to Manage Credentials for AWS #242

Open
3 tasks done
jkmathew opened this issue Aug 14, 2024 · 3 comments
Open
3 tasks done

Support Standardized Way to Manage Credentials for AWS #242

jkmathew opened this issue Aug 14, 2024 · 3 comments

Comments

@jkmathew
Copy link

jkmathew commented Aug 14, 2024

Expected/desired behavior
Currently we have to add aws_secret_key, aws_security_token etc to .rcinfo file. In a security perspective, this is not a good practice. Sametime developers might be using any other tools that uses Amazon's SDKs which expect secrets either in environment variables(AWS_ACCESS_KEY_ID, AWS_SECRET_ACCESS_KEY etc) or in the ~/.aws/credentials file (source). If XCRemoteCache also supports these methods, we can avoid checking in security keys to the repository, and it will be helpful for developers already using Amazon services.

Relevant integration setup

  • CocoaPods cocoapods-xcremotecache plugin
  • Automatic integration using xcprepare integrate ...
  • Manual integration
    [ ] Carthage << -- I dont think this option is relevant, or am I mistaken?
@polac24
Copy link
Collaborator

polac24 commented Aug 15, 2024

Secrets (or user-specific configs) should be placed in a separate file, specified in extra_configuration_file (default to user.rcinfo). All configs placed there override the .rcinfo and should not be checked into the repo.

So you can write a wrapper that before calling xcprepare integrate... places any ENV/~.aws/credentials content to that file.

@jkmathew
Copy link
Author

Thanks for looking into this!
I can see the user.rcinfo is autogenerated. If I change extra_configuration_file to point to my secrets file, will it break anything?

@polac24
Copy link
Collaborator

polac24 commented Aug 16, 2024

You can safely append AWS credentials to that autogenerated .yaml - it is safe to modify after integration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants