Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DesktopFileChooser does not release resouces used by fileDialog #9

Open
Anton-Samarskyi opened this issue Feb 25, 2024 · 1 comment

Comments

@Anton-Samarskyi
Copy link

I tried to use DesktopFileChooser in my app and noticed that some thread is still present after application is closed. I figured out that it's due to missing dispose call on fileDialog in DesktopFileChooser.

The fix looks pretty simple (I checked it locally):
fileDialog.dispose();
But better to do that in finally block.

@Anton-Samarskyi
Copy link
Author

Anton-Samarskyi commented Feb 25, 2024

Please take a look:
#10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant