fix: change deps installation method in unit tests #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently in unit tests we install dependencies from requirements_dev.txt file, exported by poetry. The problem is tat this requirements.txt file contains environment markers pointing to versions of pythons - this format causes pip to exit silently. Changed installation method to poetry install
|
🎉 This PR is included in version 4.16.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in unit tests we install dependencies from requirements_dev.txt file, exported by poetry.
The problem is that this requirements_dev.txt file contains environment markers with supported versions of pythons - this format causes pip to exit silently ans setup step is successful - job is failing later on run-test step which is unexpected.
Changed installation method to
poetry installTests:
https://github.com/splunk/splunk-add-on-for-google-workspace/pull/547
https://github.com/splunk/splunk-add-on-for-amazon-web-services/pull/1221