Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

chore: Code cleanup #112

Merged
merged 2 commits into from
Jan 11, 2023
Merged

chore: Code cleanup #112

merged 2 commits into from
Jan 11, 2023

Conversation

tarampampam
Copy link
Collaborator

@tarampampam tarampampam commented Jan 11, 2023

Description

Added

  • Listener FlushDatabaseQueryDurationListener
  • Listener RebindPaginatorListener

Changed

  • Methods invoking in listeners replaced with normal function calls

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I wrote unit tests for my code (if tests is required for my changes)
  • I have made changes in CHANGELOG.md file

@tarampampam tarampampam self-assigned this Jan 11, 2023
@codecov
Copy link

codecov bot commented Jan 11, 2023

Codecov Report

Base: 74.44% // Head: 75.05% // Increases project coverage by +0.60% 🎉

Coverage data is based on head (4f63353) compared to base (9edbcb8).
Patch coverage: 70.90% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #112      +/-   ##
============================================
+ Coverage     74.44%   75.05%   +0.60%     
+ Complexity      352      335      -17     
============================================
  Files            66       68       +2     
  Lines           951      946       -5     
============================================
+ Hits            708      710       +2     
+ Misses          243      236       -7     
Impacted Files Coverage Δ
...c/Listeners/FlushDatabaseQueryDurationListener.php 0.00% <0.00%> (ø)
src/Listeners/RebindPaginatorListener.php 0.00% <0.00%> (ø)
src/Listeners/ResetLocaleStateListener.php 92.30% <88.88%> (-7.70%) ⬇️
src/Defaults.php 100.00% <100.00%> (ø)
src/Listeners/ClearInstancesListener.php 100.00% <100.00%> (ø)
src/Listeners/FlushAuthenticationStateListener.php 83.33% <100.00%> (+11.90%) ⬆️
src/Listeners/FlushLogContextListener.php 90.00% <100.00%> (+1.11%) ⬆️
src/Listeners/FlushStrCacheListener.php 100.00% <100.00%> (+40.00%) ⬆️
src/Listeners/FlushTranslatorCacheListener.php 88.88% <100.00%> (+8.88%) ⬆️
src/Listeners/RebindAuthorizationGateListener.php 87.50% <100.00%> (+9.72%) ⬆️
... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tarampampam tarampampam marked this pull request as ready for review January 11, 2023 08:57
@tarampampam tarampampam merged commit 99d2205 into master Jan 11, 2023
@tarampampam tarampampam deleted the code-cleanup branch January 11, 2023 08:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant