-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve translatability of the new "History Page" feature #576
Comments
I did a first pass in #581 to be able to translate it in French. It could be sufficient for now. Let's iterate if we see other issues. |
As always the devil is in the details ;) With the current French translation:
Some of the issues: no space before ":", wrong accords like "ajouté" instead of "ajoutée", inconsistent upper-case, "du liste" instead of "de la liste"... Having whole strings to translate would easily solve all these issues for all languages. The weird part |
Closed via #587 |
The new History Page (#553), while awesome, is a bit hard to translate as it stands currently.
The first problem is that the type of object is uppercased, because it's the first word in English. However, it might not be the first word in other sentences. For instance:
Participant Foo added
could be translated asAjout du participant Foo
or evenAjout de Foo comme nouveau participant
.The second problem is that sentences are made of several small translatable strings such as
_("added")
,_("and")
, etc. Without context, this is hard to translate, and it also doesn't allow to reorder parts of the sentence in different languages (see example above).Translatable strings should be built as a single string with variable interpolation, for instance:
I'm not sure how to best handle markup: it can be either added to the translatable string, or can be added at interpolation time (i.e.
%(bill_description)s
would be replaced by<em>My bill description</em>
). I think the second solution is better.@Andrew-Dickinson I had a look at the template and the macros. Unfortunately it looks like it would require a large amount of changes :/
The text was updated successfully, but these errors were encountered: