Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 5.0.0 and discussion #556

Closed
eMerzh opened this issue Apr 20, 2020 · 17 comments
Closed

Release 5.0.0 and discussion #556

eMerzh opened this issue Apr 20, 2020 · 17 comments
Milestone

Comments

@eMerzh
Copy link
Contributor

eMerzh commented Apr 20, 2020

Hey, now that there are muliple person involve,

i was wondering if now is not a good time to cut a release (beta or some pre- thing)
or at least determin a good time to do that.

also, not sure what's the best channel to discuss this, github issues?

@Glandos
Copy link
Member

Glandos commented Apr 20, 2020

I don't know if some people are still using IRC, but I've created #ihatemoney on Freenode.

EDIT: now that Freenode has been killed, the channel is registered on libera.chat.

@indatwood
Copy link
Contributor

I've joined the IRC channel, let's see if there is some activity in there :-)

+1 to cut a release. I've checked the previous releases and it didn't seemed to have a beta or pre- channel, so I'm not sure how we should do it, but I believe it could be a good thing : a bunch of new features were implemented, and might break :-)

@eMerzh
Copy link
Contributor Author

eMerzh commented Apr 20, 2020

the last thing we want to get fix is the werkzeug thing.... i might have a shot at this soon.

Not a huge fan of IRC, but i'd rally to what other prefer.

@eMerzh
Copy link
Contributor Author

eMerzh commented Apr 21, 2020

now werkzeug seems to be cared for :)
we can move forward...

@zorun
Copy link
Collaborator

zorun commented Apr 23, 2020

A new release would be good! 4.1.3 is now 7 months old and things changed quite a lot.

However, there are some pretty big features (such as #553), so it would be good to gain more exposure to catch remaining bugs and regressions. The IHM doc says:

Ihatemoney follows semantic versioning. So minor/patch upgrades can be done blindly.

In that case I wouldn't upgrade blindly ;) So it would be good to either go directly to 5.0 (although there are no backwards-breaking changes I think?), or introduce beta/rc releases.

@Natim
Copy link
Member

Natim commented Apr 24, 2020

introduce beta/rc releases.

I think going with semantic versioning is good enough. If there is a bug, people can still use the previous version in the meantime, file an issue and we will do a patch release right after. We don't need to make a complex setup here IMHO.

Release early, release often.

@zorun zorun changed the title Release and discussion Release 5.0.0 and discussion Jul 17, 2020
@zorun
Copy link
Collaborator

zorun commented Jul 17, 2020

I have created a milestone to track blocking issues before 5.0.0 can be released: https://github.com/spiral-project/ihatemoney/milestone/5

In my opinion we should not merge new features before the release of 5.0.0: it already introduces many new features. We should focus on ironing out the last big issues with these features.

@zorun zorun added this to the v5 milestone Jul 21, 2020
@zorun
Copy link
Collaborator

zorun commented Jul 21, 2020

The plan is to release version 5.0.0 next Sunday (26 July), including an upcoming fix for a significant issue. The fix will also be released in stable version 4.1.5.

@zorun
Copy link
Collaborator

zorun commented Jul 14, 2021

So, it turns out there were quite a lot of fixes needed, and the motivation died down after last summer.

Let's try to release before 26 July of this year ;)

@almet
Copy link
Member

almet commented Oct 17, 2021

Hey, it's not clear what's the path to 5.0 now. I think we still need to address #848 and we'll be good to go. Is that okay for everyone?

@zorun
Copy link
Collaborator

zorun commented Oct 18, 2021

For me #848 is not blocking, and I'm against merging anything new before 5.0.0 is out.

In short: let's release 5.0.0 now!

@almet
Copy link
Member

almet commented Oct 18, 2021

Oops, sorry I'm reading this just after merging #848… Let's release!

@almet
Copy link
Member

almet commented Oct 19, 2021

And, it's done!

@almet almet closed this as completed Oct 19, 2021
@zorun
Copy link
Collaborator

zorun commented Oct 19, 2021

Thanks a lot Alexis <3

@zorun
Copy link
Collaborator

zorun commented Oct 19, 2021

@almet strange, your tags for 5.0.0 and 5.0.1 are not in the master branch, is it intended?

@almet
Copy link
Member

almet commented Oct 19, 2021

I'm not sure :-) Should it be on master? I usually create a branch to prepare everything and run make release from there, which probably explains why it's not based on the master branch.

How would you do it?

@zorun
Copy link
Collaborator

zorun commented Oct 19, 2021

The same with make release, but on the master branch :) I would find it much less confusing.

For instance, by default, git doesn't seem to download out-of-branch tags, so they are not easily visible. Also, git describe does not work properly in this case, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants