Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spin k8s scaffold: image pull secret support #30

Closed
bacongobbler opened this issue Feb 23, 2024 · 4 comments
Closed

spin k8s scaffold: image pull secret support #30

bacongobbler opened this issue Feb 23, 2024 · 4 comments
Assignees

Comments

@bacongobbler
Copy link
Collaborator

ImagePullSecrets is a list of references to secrets in the same namespace to use for pulling the image.

https://github.com/spinkube/spin-operator/blob/a401e4932595f7dd9d7980067f75bf075a4b0eec/config/crd/bases/core.spinoperator.dev_spinapps.yaml#L217C15-L233

@bacongobbler
Copy link
Collaborator Author

Marking as a nice-to-have. Users can take the output of spin k8s scaffold --from my-private-oci-registry.com/myapp:1.0.0 and add imagePullSecret metadata afterwards. A CLI option would make this a lot easier though!

@rajatjindal
Copy link
Collaborator

Hi @bacongobbler - if no one is working on this, I can pick this up. kindly let me know. thanks

@bacongobbler
Copy link
Collaborator Author

Go for it.

@rajatjindal
Copy link
Collaborator

fixed in #41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants