From 2bfec7aa09877db50e921125353abe021b23d0b5 Mon Sep 17 00:00:00 2001 From: Sorin Dumitru Date: Sun, 2 Feb 2025 07:27:24 +0000 Subject: [PATCH] sdsv3: Don't log error when connection closes If we receive a nil error on the errch it means that the connection has been closed cleanly. We shouldn't log an error in that case. Signed-off-by: Sorin Dumitru --- pkg/agent/endpoints/sdsv3/handler.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/pkg/agent/endpoints/sdsv3/handler.go b/pkg/agent/endpoints/sdsv3/handler.go index 64188a4ae1..381f194904 100644 --- a/pkg/agent/endpoints/sdsv3/handler.go +++ b/pkg/agent/endpoints/sdsv3/handler.go @@ -171,7 +171,9 @@ func (h *Handler) StreamSecrets(stream secret_v3.SecretDiscoveryService_StreamSe continue } case err := <-errch: - log.WithError(err).Error("Received error from stream secrets server") + if err != nil { + log.WithError(err).Error("Received error from stream secrets server") + } return err }