-
Notifications
You must be signed in to change notification settings - Fork 487
/
Copy pathstorage_test.go
269 lines (214 loc) · 10.9 KB
/
storage_test.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
package storage
import (
"errors"
"os"
"testing"
"time"
"github.com/spiffe/spire/pkg/common/pemutil"
"github.com/spiffe/spire/test/spiretest"
"github.com/stretchr/testify/require"
)
var (
certsA, _ = pemutil.ParseCertificates([]byte(`
-----BEGIN CERTIFICATE-----
MIIBFzCBvaADAgECAgEBMAoGCCqGSM49BAMCMBExDzANBgNVBAMTBkNFUlQtQTAi
GA8wMDAxMDEwMTAwMDAwMFoYDzAwMDEwMTAxMDAwMDAwWjARMQ8wDQYDVQQDEwZD
RVJULUEwWTATBgcqhkjOPQIBBggqhkjOPQMBBwNCAAS6qfd5FtzLYW+p7NgjqqJu
EAyewtzk4ypsM7PfePnL+45U+mSSypopiiyXvumOlU3uIHpnVhH+dk26KXGHeh2i
owIwADAKBggqhkjOPQQDAgNJADBGAiEAom6HzKAkMs3wiQJUwJiSjp9q9PHaWgGh
m7Ins/ReHk4CIQCncVaUC6i90RxiUJNfxPPMwSV9kulsj67reucS+UkBIw==
-----END CERTIFICATE-----
`))
certsB, _ = pemutil.ParseCertificates([]byte(`
-----BEGIN CERTIFICATE-----
MIIBFTCBvaADAgECAgEBMAoGCCqGSM49BAMCMBExDzANBgNVBAMTBkNFUlQtQjAi
GA8wMDAxMDEwMTAwMDAwMFoYDzAwMDEwMTAxMDAwMDAwWjARMQ8wDQYDVQQDEwZD
RVJULUIwWTATBgcqhkjOPQIBBggqhkjOPQMBBwNCAAS6qfd5FtzLYW+p7NgjqqJu
EAyewtzk4ypsM7PfePnL+45U+mSSypopiiyXvumOlU3uIHpnVhH+dk26KXGHeh2i
owIwADAKBggqhkjOPQQDAgNHADBEAiBwFhJ/GSSuPTR9cn/R4RhK/FMdboO/nOFJ
banfBh0KjQIgdAKbWkRi8d/iE7wMaW4AqGXAsgpqS3I5nQCOb8RXn0M=
-----END CERTIFICATE-----
`))
)
func TestBundle(t *testing.T) {
t.Run("load from empty storage", func(t *testing.T) {
dir := spiretest.TempDir(t)
sto := openStorage(t, dir)
actual, err := sto.LoadBundle()
require.True(t, errors.Is(err, ErrNotCached))
require.Nil(t, actual)
})
t.Run("load from same storage instance", func(t *testing.T) {
dir := spiretest.TempDir(t)
sto := openStorage(t, dir)
require.NoError(t, sto.StoreBundle(certsA))
actual, err := sto.LoadBundle()
require.NoError(t, err)
require.Equal(t, certsA, actual)
})
t.Run("load from new storage instance", func(t *testing.T) {
dir := spiretest.TempDir(t)
sto := openStorage(t, dir)
require.NoError(t, sto.StoreBundle(certsA))
sto = openStorage(t, dir)
actual, err := sto.LoadBundle()
require.NoError(t, err)
require.Equal(t, certsA, actual)
})
t.Run("populate from legacy after upgrade", func(t *testing.T) {
// Populate legacy bundle
dir := spiretest.TempDir(t)
require.NoError(t, storeLegacyBundle(dir, certsA))
// Open storage, simulating an upgrade
sto := openStorage(t, dir)
// Ensure the legacy bundle exists
actual, err := sto.LoadBundle()
require.NoError(t, err)
require.Equal(t, certsA, actual)
})
t.Run("restore from legacy after downgrade", func(t *testing.T) {
dir := spiretest.TempDir(t)
// Open storage and store the bundle
sto := openStorage(t, dir)
require.NoError(t, sto.StoreBundle(certsA))
// Assert the legacy bundle has been stored
actual, _, err := loadLegacyBundle(dir)
require.NoError(t, err)
require.Equal(t, certsA, actual)
})
t.Run("restore from legacy after downgrade/upgrade", func(t *testing.T) {
dir := spiretest.TempDir(t)
// Store to legacy storage simulating state before upgrade
require.NoError(t, storeLegacyBundle(dir, certsA))
// Open storage to simulate state after upgrade and assert legacy data
// is observed.
sto := openStorage(t, dir)
actual, err := sto.LoadBundle()
require.NoError(t, err)
require.Equal(t, certsA, actual)
// Write values to legacy storage simulating change after downgrade
require.NoError(t, storeLegacyBundle(dir, certsB))
// To be resilient against timing, manually adjust the mtime on the
// legacy data to ensure the mtime is after the storage data.
now := time.Now()
require.NoError(t, os.Chtimes(legacyBundlePath(dir), now, now.Add(time.Second)))
// Reload the sto storage (simulating the upgrade after
// downgrade) and assert new cert is observed.
sto = openStorage(t, dir)
actual, err = sto.LoadBundle()
require.NoError(t, err)
require.Equal(t, certsB, actual)
})
}
func TestSVID(t *testing.T) {
t.Run("load from empty storage", func(t *testing.T) {
dir := spiretest.TempDir(t)
sto := openStorage(t, dir)
actual, reattestable, err := sto.LoadSVID()
require.True(t, errors.Is(err, ErrNotCached))
require.Nil(t, actual)
require.False(t, reattestable)
})
t.Run("load from same storage instance", func(t *testing.T) {
dir := spiretest.TempDir(t)
sto := openStorage(t, dir)
require.NoError(t, sto.StoreSVID(certsA, true))
actual, reattestable, err := sto.LoadSVID()
require.NoError(t, err)
require.Equal(t, certsA, actual)
require.True(t, reattestable)
})
t.Run("load from new storage instance", func(t *testing.T) {
dir := spiretest.TempDir(t)
sto := openStorage(t, dir)
require.NoError(t, sto.StoreSVID(certsA, true))
sto = openStorage(t, dir)
actual, reattestable, err := sto.LoadSVID()
require.NoError(t, err)
require.Equal(t, certsA, actual)
require.True(t, reattestable)
})
t.Run("populate from legacy after upgrade", func(t *testing.T) {
// Populate legacy SVID
dir := spiretest.TempDir(t)
require.NoError(t, storeLegacySVID(dir, certsA))
// Open storage, simulating an upgrade
sto := openStorage(t, dir)
// Ensure the legacy SVID exists
actual, reattestable, err := sto.LoadSVID()
require.NoError(t, err)
require.Equal(t, certsA, actual)
require.False(t, reattestable)
})
t.Run("restore from legacy after downgrade", func(t *testing.T) {
dir := spiretest.TempDir(t)
// Open storage and store the SVID
sto := openStorage(t, dir)
require.NoError(t, sto.StoreSVID(certsA, false))
// Assert the legacy SVID has been stored
actual, _, err := loadLegacySVID(dir)
require.NoError(t, err)
require.Equal(t, certsA, actual)
})
t.Run("restore from legacy after downgrade/upgrade", func(t *testing.T) {
dir := spiretest.TempDir(t)
// Store to legacy storage simulating state before upgrade
require.NoError(t, storeLegacySVID(dir, certsA))
// Open storage to simulate state after upgrade and assert legacy data
// is observed.
sto := openStorage(t, dir)
actual, reattestable, err := sto.LoadSVID()
require.NoError(t, err)
require.Equal(t, certsA, actual)
require.False(t, reattestable)
// Write values to legacy storage simulating change after downgrade
require.NoError(t, storeLegacySVID(dir, certsB))
// To be resilient against timing, manually adjust the mtime on the
// legacy data to ensure the mtime is after the storage data.
now := time.Now()
require.NoError(t, os.Chtimes(legacySVIDPath(dir), now, now.Add(time.Second)))
// Reload the sto storage (simulating the upgrade after
// downgrade) and assert new cert is observed.
sto = openStorage(t, dir)
actual, reattestable, err = sto.LoadSVID()
require.NoError(t, err)
require.Equal(t, certsB, actual)
require.False(t, reattestable)
})
t.Run("delete from empty storage", func(t *testing.T) {
dir := spiretest.TempDir(t)
sto := openStorage(t, dir)
require.NoError(t, sto.DeleteSVID())
actual, reattestable, err := sto.LoadSVID()
require.True(t, errors.Is(err, ErrNotCached))
require.Nil(t, actual)
require.False(t, reattestable)
})
t.Run("delete from populated storage", func(t *testing.T) {
dir := spiretest.TempDir(t)
sto := openStorage(t, dir)
require.NoError(t, sto.StoreSVID(certsA, true))
require.NoError(t, sto.DeleteSVID())
actual, reattestable, err := sto.LoadSVID()
require.True(t, errors.Is(err, ErrNotCached))
require.Nil(t, actual)
require.False(t, reattestable)
})
t.Run("delete from populated storage with new instances", func(t *testing.T) {
dir := spiretest.TempDir(t)
sto := openStorage(t, dir)
require.NoError(t, sto.StoreSVID(certsA, true))
sto = openStorage(t, dir)
require.NoError(t, sto.DeleteSVID())
sto = openStorage(t, dir)
actual, reattestable, err := sto.LoadSVID()
require.True(t, errors.Is(err, ErrNotCached))
require.Nil(t, actual)
require.False(t, reattestable)
})
}
func openStorage(t *testing.T, dir string) Storage {
sto, err := Open(dir)
require.NoError(t, err)
return sto
}