Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lyrics-plus): disable genius for 1.2.31 and higher #2859

Merged
merged 10 commits into from
Feb 27, 2024
Merged

Conversation

rxri
Copy link
Member

@rxri rxri commented Feb 25, 2024

I don't have time, patience and knowledge to bypass cloudflare in a way, that genius would work all the time

@rxri rxri changed the title fix: stop assigning references fix(lyrics-plus): stop assigning references Feb 25, 2024
@rxri rxri changed the title fix(lyrics-plus): stop assigning references fix(lyrics-plus): disable genius for 1.2.31 and higher Feb 25, 2024
Copy link
Member

@CharlieS1103 CharlieS1103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rxri
Copy link
Member Author

rxri commented Feb 27, 2024

bye genius. you served us well (not at all)

@rxri rxri merged commit 5213509 into master Feb 27, 2024
9 checks passed
@rxri rxri deleted the fix/lyricsplus branch February 27, 2024 22:00
@FiftyFour7250
Copy link

Can someone please explain why genius is working fine for me now on the old version of Spotify (1.1.62.583) and spicetify (2.5.0)? Yea, it's all very old, from the time when Spotify just introduced a new interface (2020 or 2021), and I periodically had to change something so that it would continue work, but I definitely didn't bypass Cloudfare lol. I don't think Cloudfire has anything to do with it, otherwise it wouldn't work on older versions either.

I can share this dinosaur if anyone needs it.

@rxri
Copy link
Member Author

rxri commented May 23, 2024

what? This has been disabled for 1.2.31 and higher because all requests from CosmosAsync go through our cors proxy which genius requires to work inside Spotify Client. My server has been flagged by Cloudflare as a bot, requiring me to pass captcha - which well, is not possible. Spotify had ability to do external requests to the net through the client (C++ code) on versions before 1.2.31 that's why it's still available for these versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants