Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues with some Spotify pages after opening readme #523

Closed
1 task done
SunsetTechuila opened this issue Jun 22, 2023 · 1 comment · Fixed by #524
Closed
1 task done

Issues with some Spotify pages after opening readme #523

SunsetTechuila opened this issue Jun 22, 2023 · 1 comment · Fixed by #524
Labels
🐛 bug Something isn't working

Comments

@SunsetTechuila
Copy link
Contributor

SunsetTechuila commented Jun 22, 2023 •
edited
Loading

🔍 Is there already an issue for your problem?

  • I have checked older issues, open and closed

ℹ Environment / Computer Info

- Spotify version: 1.2.14.1149.ga3ae422d
- Spicetify version: 2.20.1
- OS: Windows

📝 Description

https://github.com/spicetify/spicetify-marketplace/blob/a63004fbaca313e6f85124f09ac2c1a8c0ff6a3f/src/components/ReadmePage.tsx#L71-L76

When you open a readme, the overflow-y property of the main element is set to auto and doesn't reset after you close a readme, which breaks the .search-searchCategory-SearchCategory element positioning.

📸 Screenshots

2023-06-22.141555.mp4
2023-06-22.141543.mp4
@SunsetTechuila SunsetTechuila added the 🐛 bug Something isn't working label Jun 22, 2023
@kyrie25 kyrie25 mentioned this issue Jun 22, 2023
Merged
@SunsetTechuila
Copy link
Contributor Author

Also lyrics
image

@SunsetTechuila SunsetTechuila changed the title Search page issues after opening readme Issues with some Spotify pages after opening readme Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(readme): conflict with search page spicetify/marketplace
1 participant
@SunsetTechuila