-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add controlslist attribute #56
Conversation
@@ -5,6 +5,7 @@ video | |||
:alt: You cannot display videos | |||
:autoplay: | |||
:nocontrols: | |||
:controlslist: nodownload nofullscreen noremoteplayback |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually, Sphinx list parameter are set as comma separated values in Sphinx directives, can you adpt your code to fit this unwritten and undocumented standard ? 😄
Co-authored-by: Rambaud Pierrick <12rambau@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nkr0 you now need to remove the bad value example from the documentation as it's raising an error. And catch it in the tests as it will raise an error as well.
It feels a bit odd that an error in one rst file can cause all the other tests in that directory to fail as well. Seems like sphinx reads every file in a directory even after changing from |
https://developer.mozilla.org/en-US/docs/Web/API/HTMLMediaElement/controlsList