Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.2.0: emojicodes has install time setuptools dependency #42

Closed
kloczek opened this issue Mar 11, 2023 · 4 comments · Fixed by #44
Closed

0.2.0: emojicodes has install time setuptools dependency #42

kloczek opened this issue Mar 11, 2023 · 4 comments · Fixed by #44
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed

Comments

@kloczek
Copy link

kloczek commented Mar 11, 2023 •
edited
Loading 

[tkloczko@pers-jacek SPECS]$ grep pkg_ /usr/lib/python3.8/site-packages/sphinxemoji/sphinxemoji.py
from pkg_resources import resource_filename

pkg_resources module is part of the setuptools however this module is marked as deprecated and should be replaced by importlib-metadata.
Example of the necessary change dask/distributed#5923
@Peque Peque added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers hacktoberfest labels Mar 11, 2023
@Peque
Copy link
Member

Peque commented Mar 11, 2023

Thanks for reporting @kloczek ! I encourage you to open a pull request with the necessary changes. 😊

@kloczek
Copy link
Author

kloczek commented Mar 11, 2023

Really sorry but I have already busy whole next 7-8 days.
Maybe later ..

@hotchilipowder
Copy link

Any updates?

@Peque Peque mentioned this issue Jan 17, 2024
Merged
@Peque Peque closed this as completed in #44 Jan 17, 2024
@Peque
Copy link
Member

Peque commented Jan 17, 2024

@hotchilipowder @kloczek Should be fixed in latest release (0.3.0).

@peytondmurray peytondmurray mentioned this issue Jun 26, 2024
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update build setup and dependencies Peque/emojicodes
3 participants
@Peque @hotchilipowder @kloczek