From 43b34c8a9ecb66f837ac6af3f1596c0dc2c7a83a Mon Sep 17 00:00:00 2001 From: James Knight Date: Sat, 2 Mar 2024 23:15:37 -0500 Subject: [PATCH] config: cleanup bool cfg validation Cleaning up the instance checking when sanity checking a boolean value. This simplifies an instance check and also removed an unneeded instance check. Signed-off-by: James Knight --- sphinxcontrib/confluencebuilder/config/validation.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sphinxcontrib/confluencebuilder/config/validation.py b/sphinxcontrib/confluencebuilder/config/validation.py index e0e86c94..28779003 100644 --- a/sphinxcontrib/confluencebuilder/config/validation.py +++ b/sphinxcontrib/confluencebuilder/config/validation.py @@ -53,13 +53,13 @@ def bool(self): value = self._value() if value is not None: - if isinstance(value, str) or isinstance(value, int): + if isinstance(value, (int, str)): try: str2bool(value) except ValueError as ex: msg = f'{self.key} is not a boolean string' raise ConfluenceConfigError(msg) from ex - elif not isinstance(value, bool) and not isinstance(value, int): + elif not isinstance(value, bool): msg = f'{self.key} is not a boolean type' raise ConfluenceConfigError(msg)