Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript errors after updating to latest version (v13.9.1) #811

Closed
ihorskyi opened this issue Feb 6, 2021 · 1 comment
Closed

TypeScript errors after updating to latest version (v13.9.1) #811

ihorskyi opened this issue Feb 6, 2021 · 1 comment

Comments

@ihorskyi
Copy link
Contributor

ihorskyi commented Feb 6, 2021

According to release log feature add fuzzy option to match commands was introduced in v13.9.0
Current type definition for match()is:

match(match: string | ExtendedDocument<Ext, W, Ph>, options:any): ExtendedDocument<Ext, W, Ph>

That means that options is required param now, thus all my match, matchOne, etc... methods have errors.

Screen Shot 2021-02-06 at 6 16 13 PM

Looks like options param is optional (some pun intended), so we should have it this way:

options?:any 
vs 
options:any 

I created PR to fix this and few typos along the way

@spencermountain
Copy link
Owner

released as 13.9.2
thank you for the heads-up Ihor!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants