Skip to content

Commit b6ec2ac

Browse files
sshanerealfast
authored andcommitted
Chrysler: fill cruiseState.available (commaai#24907)
* Update some signals to unified names and definitions Co-authored-by: Jonathan <jraycec@gmail.com> * steering looks good * Fix cp signals * Do steering signal changes separately * bump opendbc to master * fix fix * check available is true if enabled is true * fix * already added * bump opendbc, better cruise status names * bump opendbc * bump opendbc to master * bump panda Co-authored-by: Jonathan <jraycec@gmail.com>
1 parent abaff1f commit b6ec2ac

File tree

1 file changed

+16
-15
lines changed

1 file changed

+16
-15
lines changed

selfdrive/car/chrysler/carstate.py

+16-15
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,10 @@ def update(self, cp, cp_cam):
1818

1919
self.frame = int(cp.vl["EPS_STATUS"]["COUNTER"])
2020

21-
ret.doorOpen = any([cp.vl["DOORS"]["DOOR_OPEN_FL"],
22-
cp.vl["DOORS"]["DOOR_OPEN_FR"],
23-
cp.vl["DOORS"]["DOOR_OPEN_RL"],
24-
cp.vl["DOORS"]["DOOR_OPEN_RR"]])
21+
ret.doorOpen = any([cp.vl["BCM_1"]["DOOR_OPEN_FL"],
22+
cp.vl["BCM_1"]["DOOR_OPEN_FR"],
23+
cp.vl["BCM_1"]["DOOR_OPEN_RL"],
24+
cp.vl["BCM_1"]["DOOR_OPEN_RR"]])
2525
ret.seatbeltUnlatched = cp.vl["SEATBELT_STATUS"]["SEATBELT_DRIVER_UNLATCHED"] == 1
2626

2727
# brake pedal
@@ -51,12 +51,12 @@ def update(self, cp, cp_cam):
5151
ret.steeringRateDeg = cp.vl["STEERING"]["STEERING_RATE"]
5252
ret.gearShifter = self.parse_gear_shifter(self.shifter_values.get(cp.vl["GEAR"]["PRNDL"], None))
5353

54-
ret.cruiseState.enabled = cp.vl["ACC_2"]["ACC_STATUS_2"] == 7 # ACC is green.
55-
ret.cruiseState.available = ret.cruiseState.enabled # FIXME: for now same as enabled
54+
ret.cruiseState.available = cp.vl["DAS_3"]["ACC_AVAILABLE"] == 1 # ACC is white
55+
ret.cruiseState.enabled = cp.vl["DAS_3"]["ACC_ACTIVE"] == 1 # ACC is green
5656
ret.cruiseState.speed = cp.vl["DASHBOARD"]["ACC_SPEED_CONFIG_KPH"] * CV.KPH_TO_MS
5757
# CRUISE_STATE is a three bit msg, 0 is off, 1 and 2 are Non-ACC mode, 3 and 4 are ACC mode, find if there are other states too
5858
ret.cruiseState.nonAdaptive = cp.vl["DASHBOARD"]["CRUISE_STATE"] in (1, 2)
59-
ret.accFaulted = cp.vl["ACC_2"]["ACC_FAULTED"] != 0
59+
ret.accFaulted = cp.vl["DAS_3"]["ACC_FAULTED"] != 0
6060

6161
ret.steeringTorque = cp.vl["EPS_STATUS"]["TORQUE_DRIVER"]
6262
ret.steeringTorqueEps = cp.vl["EPS_STATUS"]["TORQUE_MOTOR"]
@@ -82,10 +82,10 @@ def get_can_parser(CP):
8282
signals = [
8383
# sig_name, sig_address
8484
("PRNDL", "GEAR"),
85-
("DOOR_OPEN_FL", "DOORS"),
86-
("DOOR_OPEN_FR", "DOORS"),
87-
("DOOR_OPEN_RL", "DOORS"),
88-
("DOOR_OPEN_RR", "DOORS"),
85+
("DOOR_OPEN_FL", "BCM_1"),
86+
("DOOR_OPEN_FR", "BCM_1"),
87+
("DOOR_OPEN_RL", "BCM_1"),
88+
("DOOR_OPEN_RR", "BCM_1"),
8989
("Brake_Pedal_State", "ESP_1"),
9090
("Accelerator_Position", "ECM_5"),
9191
("SPEED_LEFT", "SPEED_1"),
@@ -97,8 +97,9 @@ def get_can_parser(CP):
9797
("STEER_ANGLE", "STEERING"),
9898
("STEERING_RATE", "STEERING"),
9999
("TURN_SIGNALS", "STEERING_LEVERS"),
100-
("ACC_STATUS_2", "ACC_2"),
101-
("ACC_FAULTED", "ACC_2"),
100+
("ACC_AVAILABLE", "DAS_3"),
101+
("ACC_ACTIVE", "DAS_3"),
102+
("ACC_FAULTED", "DAS_3"),
102103
("HIGH_BEAM_FLASH", "STEERING_LEVERS"),
103104
("ACC_SPEED_CONFIG_KPH", "DASHBOARD"),
104105
("CRUISE_STATE", "DASHBOARD"),
@@ -118,14 +119,14 @@ def get_can_parser(CP):
118119
("SPEED_1", 100),
119120
("WHEEL_SPEEDS", 50),
120121
("STEERING", 100),
121-
("ACC_2", 50),
122+
("DAS_3", 50),
122123
("GEAR", 50),
123124
("ECM_5", 50),
124125
("WHEEL_BUTTONS", 50),
125126
("DASHBOARD", 15),
126127
("STEERING_LEVERS", 10),
127128
("SEATBELT_STATUS", 2),
128-
("DOORS", 1),
129+
("BCM_1", 1),
129130
("TRACTION_BUTTON", 1),
130131
]
131132

0 commit comments

Comments
 (0)