[v2] Bundle modules through rollup #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bundle modules through rollup to provide the smarter library in v2.
CommonJS build
Bundle the body of jsx-slack and experimental JSX automatic runtimes (#142) into the smallest chunks. The main entry will be 35.92KB (12.07KB w/ gzipped)
ES Module build
Emit minified modules with enabled
preserveModules, to keep tree-shakable that had worked in #110.Due to the design of transformation in Babel, JSX automatic runtimes are not supported ES Module. However, the structure of JSX is same in both so we should not expect no problems even if mixed.
Both
Bundle htm into jsx-slack instead of depending external. Bundled size of htm is negligibly small.