[v2] Reset stack trace to point the location of error caused JSX if possible #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jsx-slack v2 beta has already thrown helpful error message, but the stacktrace is still not useful because it is pointed out the location of internals. It would be difficult to know the cause where is.
Babel JSX transpiler has inject
__sourcesourcemap prop to all JSX elements in development mode, so would be useful for debug JSX. (@babel/plugin-transform-react-jsx-source)I've updated to reset stacktrace and point out the JSX location if the error of invalid structure was occurred in JSX element having
__sourceprop. It would become easy to find out errored JSX for developer.In above case, developer can recognize errored JSX at first glance (powered by Jest).