From 44db9eeaa196d4a53d1fdc745cd9fb10baa068db Mon Sep 17 00:00:00 2001 From: Jedd Morgan <45512892+JR-Morgan@users.noreply.github.com> Date: Mon, 18 Nov 2024 10:39:16 +0000 Subject: [PATCH 1/2] revert collection speckle_type change --- src/specklepy/objects/other.py | 16 +++------------- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/src/specklepy/objects/other.py b/src/specklepy/objects/other.py index 76a01e46..fbf4d436 100644 --- a/src/specklepy/objects/other.py +++ b/src/specklepy/objects/other.py @@ -295,27 +295,17 @@ class RevitParameter(Base, speckle_type="Objects.BuiltElements.Revit.Parameter") value: Any = None applicationUnitType: Optional[str] = None # eg UnitType UT_Length applicationUnit: Optional[str] = None # DisplayUnitType eg DUT_MILLIMITERS - applicationInternalName: Optional[ - str - ] = None # BuiltInParameterName or GUID for shared parameter + applicationInternalName: Optional[str] = ( + None # BuiltInParameterName or GUID for shared parameter + ) isShared: bool = False isReadOnly: bool = False isTypeParameter: bool = False -@deprecated(version="2.20", reason="Namespace changed, collectionType deprecated") class Collection( Base, speckle_type="Speckle.Core.Models.Collection", detachable={"elements"} ): name: Optional[str] = None collectionType: Optional[str] = None elements: Optional[List[Base]] = None - - -class Collection( # noqa: F811 - Base, - speckle_type="Speckle.Core.Models.Collections.Collection", - detachable={"elements"}, -): - name: Optional[str] = None - elements: Optional[List[Base]] From c076fbb29bd77e0cef395372e9db562aadb85f5a Mon Sep 17 00:00:00 2001 From: Jedd Morgan <45512892+JR-Morgan@users.noreply.github.com> Date: Mon, 18 Nov 2024 10:43:35 +0000 Subject: [PATCH 2/2] black --- src/specklepy/objects/other.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/specklepy/objects/other.py b/src/specklepy/objects/other.py index fbf4d436..5a2576e4 100644 --- a/src/specklepy/objects/other.py +++ b/src/specklepy/objects/other.py @@ -295,9 +295,9 @@ class RevitParameter(Base, speckle_type="Objects.BuiltElements.Revit.Parameter") value: Any = None applicationUnitType: Optional[str] = None # eg UnitType UT_Length applicationUnit: Optional[str] = None # DisplayUnitType eg DUT_MILLIMITERS - applicationInternalName: Optional[str] = ( - None # BuiltInParameterName or GUID for shared parameter - ) + applicationInternalName: Optional[ + str + ] = None # BuiltInParameterName or GUID for shared parameter isShared: bool = False isReadOnly: bool = False isTypeParameter: bool = False