Cannot save the user model twice in the same request

[Moundlen]

Describe the bug
Hi,
Sorry if this has already been asked but I'm using Laravel fortify to register new users, once user is registered I automatically log him in but I have a listener that listens for Login and automatically edits the user IP and last login and saves the user again. When the user is saved again I get an error Duplicate entry '7-153-User' for key 'model_has_roles.PRIMARY'.
I fixed the issue by saving quietly but is this expected behavior ?
Now everytime I save a user in the same lifetime cycle it just crashes.
It seems to come from the use of attach instead of sync in the HasRoles trait line 168. see #2420
Did not have this issue before because I migrated from v4 to v6.

Versions

• spatie/laravel-permission package version: 6.4.0
• laravel/framework package: 10.48.3

PHP version: 8.2.16

Database version: mysql 8.0.32

To Reproduce

• Create a new User
• Sync or Assign role to the user
• Save the User
• Save the User again

My listener:

public function login(Login $event): void
    {
        try {
            /** @var User $user */
            $user = $event->user;
            activity('Auth')->by($user)
                ->withProperty('IP', request()->getClientIp())
                ->log('Login');

            $user->last_login = Carbon::now();
            $user->last_ip = request()->getClientIp();
            $user->saveQuietly();
        } catch (\Exception $exception) {
            report($exception);
        }
    }

Expected behavior
I would expect the save to not throw an error if I save the User twice.

Environment (please complete the following information, because it helps us investigate better):

• OS: ubuntu
• Version: 22.04

[drbyte]

1. How are you registering roles to the model? It would be helpful to see what your code is for that, since it should have already finished persisting things and letting go of what was specified to be attached. Seeing your code would help.
2. In your listener, perhaps you can call $user->fresh() to have a clean unique instance before updating its properties and saving?

[Moundlen]

Hi, here is a simple code to reproduce created a new empty laravel 11 project.

<?php

use Illuminate\Support\Facades\Route;
use Spatie\Permission\Models\Role;
use Spatie\Permission\Models\Permission;

Route::get('/', function () {
    $user = new \App\Models\User([
        'name' => \Illuminate\Support\Str::random(),
        'password' => \Illuminate\Support\Str::random(),
        'email' => \Illuminate\Support\Str::random() . '@example.com',
    ]);
    if (Role::where('name', 'writer')->doesntExist()) {
        $role = Role::create(['name' => 'writer']);
        $permission = Permission::create(['name' => 'edit articles']);
        $role->givePermissionTo($permission);
    }
    $user->assignRole('writer');

    $user->save();
    $user = $user->fresh();
    $user->save();
});

[drbyte]

Thanks for the code sample.

Yes, if you're creating a User with new, then it is not yet persisted into the database, and attached pivots are getting duplicated when calling save().

However, if you first ->save() that unpersisted User before calling assignRole()/etc, subsequent saves will not be problematic.

Also, if you use User::create() instead of new User, none of these problems occur.

[drbyte]

@erikn69 I'm interested in your thoughts about how to avoid these "Duplicate entry" errors when attaching to an un-persisted model.

Ref: #2419 #2420 #2574
Ref: https://github.com/laravel/framework/blob/master/src/Illuminate/Database/Eloquent/Relations/Concerns/InteractsWithPivotTable.php

[erikn69]

I think it is a problem that has always been present.
A validation could be added,
I would have to do tests, I think that adding wasRecentlyCreated would solve it

laravel-permission/src/Traits/HasPermissions.php

Lines 405 to 414 in ce67a8b

	$class::saved(
	function ($object) use ($permissions, $model, $teamPivot) {
	if ($model->getKey() != $object->getKey()) {
	return;
	}
	$model->permissions()->attach($permissions, $teamPivot);
	$model->unsetRelation('permissions');
	}
	);
	}

[ue-shuston]

Currently running into the same issue. Any idea when #2658 will be merged?

[parallels999]

@ue-shuston hi, did you test #2658? does it work?

[ue-shuston]

@parallels999 Yes, for our use case the changes made in #2658 worked.

Alternatively, changing ->attach( to ->sync( on:

laravel-permission/src/Traits/HasPermissions.php

Line 410 in c99dca7

$model->permissions()->attach($permissions, $teamPivot);

laravel-permission/src/Traits/HasRoles.php

Line 168 in c99dca7

$model->roles()->attach($roles, $teamPivot);

also resolved the problem.

[parallels999]

Alternatively, changing ->attach( to ->sync( on:

That would return an old problem: #2419 (comment)

[ue-shuston]

@parallels999 Understood, we had assumed that using ->sync( was too obvious of a fix, and that there had been some reason to not utilize it. But #2658 does resolve this issue. Is there a schedule for it to be merged?