runBeforePolicies() or runAfterPolicies()

[ziming]

Currently, if a spatie permission shares the same name as a laravel policy, spatie permissions is run 1st.

Hence the documentation suggest naming spatie permissions differently from laravel policies.

However I think there is an alternate solution that would be nice if Spatie Permissions support it too. 1 that is adopted by Bouncer

For context, Bouncer by default run its permission checks after Laravel policies run (my preferred choice. But it can be configured to before with this

// in AppService Provider

BouncerFacade::runBeforePolicies(); // Spatie permissions current default behaviour

Behind the scenes Bouncer does this

// Bouncer.php
public function runBeforePolicies($boolean = true)
    {
        $this->guard->slot($boolean ? 'before' : 'after');

        return $this;
    }

// Guard.php

/**
     * Set or get which slot to run the clipboard's checks.
     *
     * @param  string|null  $slot
     * @return $this|string
     */
    public function slot($slot = null)
    {
        if (is_null($slot)) {
            return $this->slot;
        }

        if (! in_array($slot, ['before', 'after'])) {
            throw new InvalidArgumentException(
                "{$slot} is an invalid gate slot"
            );
        }

        $this->slot = $slot;

        return $this;
    }

    /**
     * Register the clipboard at the given gate.
     *
     * @param  \Illuminate\Contracts\Auth\Access\Gate  $gate
     * @return $this
     */
    public function registerAt(Gate $gate)
    {
        $gate->before(function () {
            return $this->runBeforeCallback(...func_get_args());
        });

        $gate->after(function () {
            return $this->runAfterCallback(...func_get_args());
        });

        return $this;
    }

    /**
     * Run the gate's "before" callback.
     *
     * @param  \Illuminate\Database\Eloquent\Model  $authority
     * @param  string  $ability
     * @param  mixed  $arguments
     * @param  mixed  $additional
     * @return bool|null
     */
    protected function runBeforeCallback($authority, $ability, $arguments = [])
    {
        if ($this->slot != 'before') {
            return;
        }

        if (count($arguments) > 2) {
            return;
        }

        $model = isset($arguments[0]) ? $arguments[0] : null;

        return $this->checkAtClipboard($authority, $ability, $model);
    }

    /**
     * Run the gate's "before" callback.
     *
     * @param  \Illuminate\Database\Eloquent\Model  $authority
     * @param  string  $ability
     * @param  mixed  $result
     * @param  array  $arguments
     * @return bool|null
     */
    protected function runAfterCallback($authority, $ability, $result, $arguments = [])
    {
        if (! is_null($result)) {
            return $result;
        }

        if ($this->slot != 'after') {
            return;
        }

        if (count($arguments) > 2) {
            return;
        }

        $model = isset($arguments[0]) ? $arguments[0] : null;

        return $this->checkAtClipboard($authority, $ability, $model);
    }

It would be nice if Spatie permissions allow us to define its permissions check to run before or after Laravel native Policies too.

[erikn69]

Make a PR without break current behavior

[ziming]

If I know how to add this functionality I would have made a PR instead of making a suggestion. If anyone else is able to do it, thanks a lot! If not, it's fine too :)