From a9f32a63f1a7cfc51e0977ba77869091d2060612 Mon Sep 17 00:00:00 2001 From: Tim van Uum Date: Thu, 2 Dec 2021 15:51:19 +0100 Subject: [PATCH 1/2] Update Conversion.php Check for lower and uppercase image extensions but always return the originalExtension --- src/Conversions/Conversion.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Conversions/Conversion.php b/src/Conversions/Conversion.php index ec2e1baa5..888cd1ff8 100644 --- a/src/Conversions/Conversion.php +++ b/src/Conversions/Conversion.php @@ -205,7 +205,7 @@ public function getResultExtension(string $originalFileExtension = ''): string { if ($this->shouldKeepOriginalImageFormat()) { if (in_array(strtolower($originalFileExtension), ['jpg', 'jpeg', 'pjpg', 'png', 'gif'])) { - return strtolower($originalFileExtension); + return $originalFileExtension; } } From 366d2666b2023f5a0425fd74254c067f6516d3ba Mon Sep 17 00:00:00 2001 From: Tim van Uum Date: Thu, 2 Dec 2021 16:50:09 +0100 Subject: [PATCH 2/2] Change test to check if return extension is indeed uppercase as is the original extension. --- tests/Conversions/ConversionFileExtensionTest.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/Conversions/ConversionFileExtensionTest.php b/tests/Conversions/ConversionFileExtensionTest.php index e11c4e8cd..1e6da4aa9 100644 --- a/tests/Conversions/ConversionFileExtensionTest.php +++ b/tests/Conversions/ConversionFileExtensionTest.php @@ -27,7 +27,7 @@ public function it_can_keep_the_original_image_format_if_the_original_file_is_an { $media = $this->testModelWithConversion->addMedia($this->getUppercaseExtensionTestPng())->toMediaCollection(); - $this->assertExtensionEquals('png', $media->getUrl('keep_original_format')); + $this->assertExtensionEquals('PNG', $media->getUrl('keep_original_format')); } /** @test */