Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer requirements #9

Closed
alxy opened this issue Mar 3, 2015 · 2 comments
Closed

Composer requirements #9

alxy opened this issue Mar 3, 2015 · 2 comments

Comments

@alxy
Copy link

alxy commented Mar 3, 2015

Hi,
is there any reason you require orchestra/testbench in you composer.json: https://github.com/freekmurze/laravel-backup/blob/master/composer.json#L26
This leads to the download of the entire laravel/framework (and dependencies) if I use this app for example in an OctoberCMS plugin: https://github.com/alxy/oc-backup-plugin

Couldn't you at least put this in require-dev?

@freekmurze
Copy link
Member

Hi,

this is corrected in version 2.0.3.

Keep in mind though that this package is intended to be used in Laravel 5. Some L5 specific functionality is used. I haven't tested it in OctoberCMS.

@alxy
Copy link
Author

alxy commented Mar 3, 2015

Thanks!

@microdesign microdesign mentioned this issue Oct 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants