Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mail notification is sent when it's not supposed to #1879

Closed
rcerljenko opened this issue Jan 30, 2025 · 7 comments
Closed

Mail notification is sent when it's not supposed to #1879

rcerljenko opened this issue Jan 30, 2025 · 7 comments

Comments

@rcerljenko
Copy link
Contributor

Hi,

Since latest update (9.2.4) system is sending mail notification even if it doesn't suppose to.

Given this config:
Image

CleanupWasSuccessfulNotification shouldn't be sent but it is. I'm suspecting that it has something to do with the latest PR... specifically this line:

https://github.com/spatie/laravel-backup/pull/1873/files#diff-18d9e9c6768a133f4fc7723d566dc36b5a1a07bee3c30396619c76cd85422bfeR31

@Okipa
Copy link

Okipa commented Jan 30, 2025

I can confirm this erratic behavior on my end 👍

@freekmurze
Copy link
Member

@pxpm Could you take a look at this? If we don't find a fix for this soonish, I'll revert the PR.

@pxpm
Copy link
Contributor

pxpm commented Jan 30, 2025

On it 👍

@julesjanssen
Copy link

The same applies to the source.files part of the config. It's no longer possible to leave that array empty.

@freekmurze
Copy link
Member

Fixed in the latest release.

@rcerljenko
Copy link
Contributor Author

many thanks guys!

@Okipa
Copy link

Okipa commented Feb 1, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants