Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Declaration of Spatie\Fractalistic\ArraySerializer::collection(string $resourceKey, array $data) invalid #56

Closed
lukasvy opened this issue Apr 12, 2022 · 2 comments
Closed

Declaration of Spatie\Fractalistic\ArraySerializer::collection(string $resourceKey, array $data) invalid #56

lukasvy opened this issue Apr 12, 2022 · 2 comments

Comments

@lukasvy
Copy link
Contributor

lukasvy commented Apr 12, 2022

It seems guys at League\Fractal updated definitions that are used within Spatie\Fractalistic\ArraySerializer which in term broke whole library.

Declaration of Spatie\Fractalistic\ArraySerializer::collection(string $resourceKey, array $data): array must be compatible with League\Fractal\Serializer\ArraySerializer::collection(?string $resourceKey, array $data): array
@freekmurze
Copy link
Member

Could you send a PR that fixes this at our end?

This was referenced Apr 12, 2022
Closed
Merged
@spatie-bot
Copy link

Dear contributor,

because this issue seems to be inactive for quite some time now, I've automatically closed it. If you feel this issue deserves some attention from my human colleagues feel free to reopen it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@freekmurze @lukasvy @spatie-bot