Fix EmptyStackException thrown by nokogiri-java when an xlink:href attribute shows up with an empty XmlBaseStack #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flavorjones
added a commit
that referenced
this pull request
Mar 19, 2013
Fix EmptyStackException thrown by nokogiri-java when an xlink:href attribute shows up with an empty XmlBaseStack
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a revision of the PR posted by @bilts
#534
The test now appears to pass in both MRI 1.9.3 and jruby-head 1.9.2. The assumption is:
If a node has an xml:base or inherits one, the xlink:href will not affect the node's xml base.
If the node doesn't have an xml:base or inherit one, AND the xlink:href attribute begins with 'http://', the xlink:href will set the node's xml base.