C14n fix and new parameters #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 8, 2011 17:07
…t also Namespaces
…icalize. Added C14N constants to Nokogiri::XML.
tenderlove
added a commit
that referenced
this pull request
Nov 17, 2011
C14n fix and new parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed the segfaults when using node selection block. Turns out the block_caller method was assuming that the node parameter is always an xmlNodePtr, when in fact it can also be an xmlNsPtr.
I also added parameters for the other xmlC14NExecute options (mode, inclusive_ns_prefixes and with_comments), and added a Node#canonicalize convenience method.
I think this fixes #226, so maybe we can finally have c14n support in Ruby! But please review the code, since it's the first time I'm working on Nokogiri.